Smooth Motion Streak movement #9693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
效果请参考企业微盘 https://drive.weixin.qq.com/s?k=ADcAmwdCAAogJ4I3so |
jareguo
commented
Nov 21, 2021
| } | ||
| findLast = true; | ||
|
|
||
| normal(_normal, dir); |
There was a problem hiding this comment.
TODO：这里直接用法向量做为两个顶点的位置，效果并不是最好的，会有很多线段的交叉
比较好的做法是判断线段顶点的距离，确保距离之合最小，一旦发现交叉，交换左右两侧的顶点（位置换，UV 不能换），效果就会好很多。
jareguo
commented
Nov 22, 2021
| @@ -61,6 +61,7 @@ var MotionStreak = cc.Class({ | |||
|
|
|||
| ctor () { | |||
| this._points = []; | |||
There was a problem hiding this comment.
我是不太能理解渲染数据挂在组件上的行为。
谁使用，就应该谁持有。
| @@ -77,6 +77,11 @@ function computeMiter (miter, lineA, lineB, halfThick, maxMultiple) { | |||
| } | |||
|
|
|||
| export default class MotionStreakAssembler extends Assembler2D { | |||
| constructor () { | |||
| super(); | |||
| this._tailShortenTime = 0; | |||
There was a problem hiding this comment.
用来计算最后一节拖尾缩短的速度。原有算法不对，导致时灵时不灵。
| } | ||
| // update head | ||
| cur.setPoint(tx, ty); | ||
| cur.time = fadeTime + dt; |
There was a problem hiding this comment.
只有移动了，才能重新激活拖尾（的时间）。如果不动，拖尾就应该逐渐消失。原先每一帧都重新激活拖尾，会导致最后一节拖尾突然消失。
| } | ||
| } | ||
| else { | ||
| this._tailShortenTime = p.time; |
There was a problem hiding this comment.
如果 point 数量不足，不缩短拖尾，因为缺少计算出平均速度的变量。会导致移动速度比较慢时，第一节拖尾始终出不来。
2youyou2
approved these changes
Mar 9, 2022
|
不要把开发者当做小白鼠，优化完没有经过测试和验收的吗，看看论坛吧，一堆bug啊啊啊啊啊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
优化的点：
警告：